@import url('http://dev.wikia.com/...), 3rd-party scripts/iframes being loaded by JS, and API requests. Images being loaded via HTTP <i>will</i> work in both CSS and JS for most browsers (since they're considered display content) but it'd be good to update those too (where possible).
</p>
3,306
pages
ALL POSTSUpcoming HTTPS transition
<p>With the transition to site-wide HTTPS upcoming, it would be good to go through and check/fix any protocol-specific code on the wiki before it becomes a visible issue. I assume a fair amount could be fixed by bot, though there'll likely be cases that need hand-fixing.
</p><p>Probably the most common issues are CSS imports specifically using HTTP (like
(Edited by OneTwoThreeFall)
<p>I made a list of pages in MediaWiki namespace that include "http" in their content (this also includes pages with "https://" in their content and pages with links to http://dev.wikia.com/wiki/Wiki_page, but better safe than sorry) on here now, so feel free to edit out scripts that are already checked for HTTPS migrations/migrated.
</p>
(Edited by KockaAdmiralac)
<p>I've been going through the dump using "http:" (with the colon) as my search term - that cuts out the https false positives, and I don't think it would leave anything out (I hope not!).
</p>
(Edited by OneTwoThreeFall)
0
Maybe run a dump/search after it all gets reviewed and see if any is left?
(Edited by Sophiedp)
<p>Update on this: It looks like Staff are updating their URLs to respect
wgScriptPath because it looks like wikis are going to have /wiki/language_code as their script path and probably /wiki/language_code/$1 as their article path. We probably need to update all the scripts again to respect wgScriptPath and wgArticlePath as well, too...
</p>
(Edited by KockaAdmiralac)
1
<p>There will be public communication etc. about script-related changes when everything is finalized. No need to rush ?
</p>
(Edited by TK-999)
0
<p>While we're on the topic, should we use
mw.config.get('wgArticlePath') or wgArticlePath?
</p>
(Edited by Sophiedp)
<p>I believe wgArticlePath is declared everywhere. But on testing wgIsDarkTheme (for source editor - EditPageLayout),
mw.config.get method is <i>usually</i> safer:
</p>
-
wgIsDarkThemereturns "Uncaught ReferenceError" -
window.wgIsDarkThemereturns undefined -
mw.config.get('wgIsDarkTheme')returns null
(Edited by MACH-59330)
<p>Yep, using
mw.config is the best option.
</p><p>The global variables only exist for legacy reasons - using them in newer versions of MediaWiki outputs a console message recommending mw.config instead. There's a bit more info at the MediaWiki wiki.
</p><p>edit: didn't mean that to be a reply, I accidentally hit the quote button.
</p>
(Edited by OneTwoThreeFall)
<p>Another update: Wikia has made HTTPS available to everybody for opt-in in preferences (under Under the Hood) so now we can test whether we missed some scripts during the migration.
</p>
(Edited by KockaAdmiralac)
<p>Just noticed that, nice to see it finally start rolling out!
</p><p>I quickly looked through the latest (2018-03-17) dump using
['"]http:// regexp search and only found two occurrences in actual code. I fixed one, and the other (MediaWiki:RecentChangesMultiple/code.js) I left as that script is fairly complex and is marked deprecated anyway. Most other results were from talk messages, personal CSS/JS pages, or code comments, so they're not too important to change.
</p>
(Edited by OneTwoThreeFall)